Skip to content

Use 64 bit candidate pair packet counters - #1031

Merged
JoTurk merged 1 commit into
mainfrom
stats-64bit-packet-counters
Oct 6, 2026
Merged

JoTurk merged 1 commit into
mainfrom
stats-64bit-packet-counters

Conversation

@fippo

@fippo fippo commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

packetsSent and packetsReceived are unsigned long long in the specification since w3c/webrtc-stats#494

packetsSent and packetsReceived are unsigned long long in the
specification since w3c/webrtc-stats#494
@fippo

fippo commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

api check is ok since we can do this in the major RC?

Removes a widening conversion from pion/webrtc#3612

@JoTurk

JoTurk commented Oct 6, 2026

Copy link
Copy Markdown
Member

@fippo yeah it's fine

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.77%. Comparing base (85c387f) to head (5886b3c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
- Coverage   91.88%   91.77%   -0.12%     
==========================================
  Files          45       45              
  Lines        5447     5447              
==========================================
- Hits         5005     4999       -6     
- Misses        442      448       +6     
Flag Coverage Δ
go 91.77% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk
JoTurk merged commit 54863cd into main Oct 6, 2026
19 of 20 checks passed
@JoTurk
JoTurk deleted the stats-64bit-packet-counters branch October 6, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants