Skip to content

Honor interface/IP filters for srflx and relay STUN requests #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirzooro merged 1 commit into from
Mar 15, 2026
Merged

Honor interface/IP filters for srflx and relay STUN requests #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions agent_options_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,15 +513,15 @@ func TestMultipleConfigOptions(t *testing.T) {
func TestWithInterfaceFilter(t *testing.T) {
t.Run("sets interface filter", func(t *testing.T) {
filter := func(interfaceName string) bool {
return interfaceName == "eth0"
return interfaceName == "eth0" // nolint:goconst
}

agent, err := NewAgentWithOptions(WithInterfaceFilter(filter))
assert.NoError(t, err)
defer agent.Close() //nolint:errcheck

assert.NotNil(t, agent.interfaceFilter)
assert.True(t, agent.interfaceFilter("eth0"))
assert.True(t, agent.interfaceFilter("eth0")) // nolint:goconst
assert.False(t, agent.interfaceFilter("wlan0"))
})

Expand Down Expand Up @@ -549,7 +549,7 @@ func TestWithInterfaceFilter(t *testing.T) {

assert.NotNil(t, agent.interfaceFilter)
assert.True(t, agent.interfaceFilter("lo"))
assert.False(t, agent.interfaceFilter("eth0"))
assert.False(t, agent.interfaceFilter("eth0")) // nolint:goconst
})
Comment thread
JoTurk marked this conversation as resolved.
}

Expand Down
Loading
Loading