Skip to content

Include the header in ExtendedReport.MarshalSize #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaphaelFakhri wants to merge 1 commit into from
Closed

Include the header in ExtendedReport.MarshalSize #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extended_report.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ func (b *UnknownReportBlock) unpackBlockHeader() {

// MarshalSize returns the size of the packet once marshaled.
func (x ExtendedReport) MarshalSize() int {
return wireSize(x)
return headerLength + wireSize(x)
}

// Marshal encodes the ExtendedReport in binary.
Expand Down
19 changes: 19 additions & 0 deletions extended_report_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,3 +264,22 @@ func TestDecode(t *testing.T) {
}
assert.True(t, includeSenderSSRC, "DestinationSSRC does not include the SenderSSRC")
}

func TestExtendedReportMarshalSize(t *testing.T) {
packet := testPacket()
rawPacket, err := packet.Marshal()
assert.NoError(t, err)
assert.Equal(t, len(rawPacket), packet.MarshalSize())

compound := CompoundPacket{
&SenderReport{SSRC: 1},
&SourceDescription{Chunks: []SourceDescriptionChunk{{
Source: 1,
Items: []SourceDescriptionItem{{Type: SDESCNAME, Text: "cname"}},
}}},
packet,
}
rawCompound, err := compound.Marshal()
assert.NoError(t, err)
assert.Equal(t, len(rawCompound), compound.MarshalSize())
}