🛡️ Sentinel: Fix sub-process spawn error handling to prevent hangs - #14
🛡️ Sentinel: Fix sub-process spawn error handling to prevent hangs#14piyyy314 wants to merge 1 commit into
Conversation
Add an error listener to child processes in `execute` to reject the promise gracefully if spawning fails, avoiding unhandled exceptions or permanent hangs. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This PR improves the robustness of subprocess execution within the TypeScript CLI codebase.
Previously,
src/lib/sub-process.tshad no event listener for the'error'event on the spawnedChildProcess. This meant that if spawning the child process failed (e.g. command not found or execution permissions issues), Node.js would throw an unhandled exception or leave the returned promise permanently pending, causing a potential hang or crash.We resolved this by:
'error'event listener on the spawned process (proc.on('error', ...)) to reject the promise gracefully.test/jest/unit/lib/sub-process.spec.tsto cover successful execution, non-zero exit codes, and process spawning failures.PR created automatically by Jules for task 2534864274848222602 started by @piyyy314