Skip to content

🛡️ Sentinel: Fix sub-process spawn error handling to prevent hangs - #14

Draft
piyyy314 wants to merge 1 commit into
mainfrom
sentinel-subprocess-robustness-2534864274848222602
Draft

🛡️ Sentinel: Fix sub-process spawn error handling to prevent hangs#14
piyyy314 wants to merge 1 commit into
mainfrom
sentinel-subprocess-robustness-2534864274848222602

Conversation

@piyyy314

Copy link
Copy Markdown
Owner

This PR improves the robustness of subprocess execution within the TypeScript CLI codebase.

Previously, src/lib/sub-process.ts had no event listener for the 'error' event on the spawned ChildProcess. This meant that if spawning the child process failed (e.g. command not found or execution permissions issues), Node.js would throw an unhandled exception or leave the returned promise permanently pending, causing a potential hang or crash.

We resolved this by:

  1. Adding a 'error' event listener on the spawned process (proc.on('error', ...)) to reject the promise gracefully.
  2. Adding dedicated Jest unit tests under test/jest/unit/lib/sub-process.spec.ts to cover successful execution, non-zero exit codes, and process spawning failures.

PR created automatically by Jules for task 2534864274848222602 started by @piyyy314

Add an error listener to child processes in `execute` to reject
the promise gracefully if spawning fails, avoiding unhandled
exceptions or permanent hangs.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b43191b7-0269-49e8-8a89-6af2a1154dff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@piyyy314

Copy link
Copy Markdown
Owner Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant