π‘οΈ Sentinel: Redact sensitive headers and proxy credentials in request debug logs - #33
π‘οΈ Sentinel: Redact sensitive headers and proxy credentials in request debug logs#33piyyy314 wants to merge 1 commit into
Conversation
β¦ logs Redact sensitive authentication headers (such as authorization, x-api-key, session-token, cookie) and basic auth credentials in proxy URIs before outputting request payloads and proxy URLs to debug logs. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the βοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
β Snyk checks have passed. No issues have been found so far.
π» Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
π¨ Severity: HIGH
π‘ Vulnerability: Sensitive authentication headers and proxy basic auth credentials were included in cleartext when outputting request payloads and proxy URIs to CLI debug logs (
debugandsnykDebug).π― Impact: Secrets (tokens, API keys, session cookies, proxy credentials) could leak into log files, terminal streams, or log monitoring tools when debug logging is enabled.
π§ Fix: Implemented
sanitizePayloadForLogandsanitizeUrlForLoghelpers insrc/lib/request/request.tsto redact sensitive headers and proxy credentials before logging.β Verification: Added unit tests in
test/jest/unit/lib/request/request.spec.tsto verify redaction behavior.PR created automatically by Jules for task 10626413904610122093 started by @piyyy314