pip_library: ensure pip_flags is always a string - #314
Merged
chrisnovakovic merged 1 commit intoJul 27, 2026
Merged
Conversation
When the `pip_flags` parameter and the `PipFlags` plugin configuration option are both undefined, the output of `pip_library` contains the [none](https://pypi.org/project/none/) module as well as the desired one because `None` is erroneously passed as an argument to pip. Ensure `None` is not passed to pip under these circumstances. Fixes please-build#313.
SpangleLabs
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
pip_flagsparameter and thePipFlagsplugin configuration option are both undefined, the output ofpip_librarycontains the none module as well as the desired one becauseNoneis erroneously passed as an argument to pip. EnsureNoneis not passed to pip under these circumstances.Fixes #313.