Skip to content

Condition always true #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btry merged 1 commit into from
Oct 7, 2026
Merged

Condition always true #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions src/Engine/V1/AbstractPermanent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,34 +75,28 @@ public function getCarbonEmissionPerDay(DateTimeInterface $day, Source_Zone $sou
$start_time->setTime(0, 0, 0, 0);
$length = new DateInterval('PT' . 86400 . 'S'); // 24h = 86400 seconds
$source = Source::getById($source_zone->fields['plugin_carbon_sources_id']);
$fallback_source_zone = null;
$iterator = null;
$expected_count = 24;

// Try to read real time carbon intensities
if ($source->fields['fallback_level'] === 0) {
$iterator = $this->requestCarbonIntensitiesPerDay(DateTimeImmutable::createFromMutable($start_time), $length, $source_zone);
if ($iterator->count() === 0) {
// Need to fallback to an alternate source
$fallback_source_zone = new Source_Zone();
if (!$fallback_source_zone->getFallbackFromDB($source_zone)) {
$fallback_source_zone = null;
if ($fallback_source_zone->getFallbackFromDB($source_zone)) {
$row = array_fill(0, $expected_count, $this->getFallbackCarbonIntensity($start_time, $fallback_source_zone));
$iterator = new ArrayObject($row);
$iterator = $iterator->getIterator();
}
}
} else {
// The source is already a fallback (exapmple: Quebec does has any realtime source)
$fallback_source_zone = $source_zone;
}

$expected_count = 24;

// Try a fallback source
if ($fallback_source_zone !== null) {
$row = array_fill(0, $expected_count, $this->getFallbackCarbonIntensity($start_time, $fallback_source_zone));
$row = array_fill(0, $expected_count, $this->getFallbackCarbonIntensity($start_time, $source_zone));
$iterator = new ArrayObject($row);
$iterator = $iterator->getIterator();
}

$count = $iterator ? $iterator->count() : 0;
$count = $iterator->count();
if ($count != $expected_count) {
trigger_error(sprintf(
'required count of carbon intensity %d samples not met. Got %d samples for date %s',
Expand Down
16 changes: 6 additions & 10 deletions src/Engine/V1/AbstractSwitchable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,24 +150,20 @@ protected function computeEmissionPerDay(DateTimeImmutable $start_time, TrackedI
if ($iterator->count() < $expected_count) {
// Need to fallback to an alternate source
$fallback_source_zone = new Source_Zone();
if (!$fallback_source_zone->getFallbackFromDB($source_zone)) {
$fallback_source_zone = null;
if ($fallback_source_zone->getFallbackFromDB($source_zone)) {
$row = array_fill(0, $expected_count, $this->getFallbackCarbonIntensity($start_time, $fallback_source_zone));
$iterator = new ArrayObject($row);
$iterator = $iterator->getIterator();
}
}
} else {
// The source is already a fallback (exapmple: Quebec does has any realtime source)
$fallback_source_zone = $source_zone;
}


// Try a fallback source
if ($fallback_source_zone !== null) {
$row = array_fill(0, $expected_count, $this->getFallbackCarbonIntensity($start_time, $fallback_source_zone));
$row = array_fill(0, $expected_count, $this->getFallbackCarbonIntensity($start_time, $source_zone));
$iterator = new ArrayObject($row);
$iterator = $iterator->getIterator();
}

$count = $iterator ? $iterator->count() : 0;
$count = $iterator->count();
if ($count != $expected_count) {
trigger_error(sprintf(
"required count of carbon intensity %d samples not met. Got %d samples for date %s",
Expand Down
Loading