You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue #1356 reported that the SuiBets GET /api/events/upcoming endpoint was returning a 400 Bad Request.
Upon auditing the runtime logic, I found that fetchRawEvents was already successfully refactored to synthesize events from /api/p2p/offers instead of using the broken endpoint. However, the legacy endpoint was left dangling in the api.ts documentation, leading to the open issue.
This PR simply removes the deprecated endpoint from the documentation to align it with the current implementation and safely closes the stale issue.
Removes the deprecated GET /api/events/upcoming line from the SuiBets API reference comment. This does not affect runtime SDK behavior.
Blast Radius
Documentation-only comment in core/src/exchanges/suibets/api.ts; no exchange implementation, SDK, schema, or router code changes.
Consumer Verification
Before (base branch):
The comment listed GET /api/events/upcoming as a documented SuiBets endpoint, although the file explicitly has no runtime exports.
After (PR branch):
The stale endpoint line is removed. There is no consumer-visible API behavior to exercise because api.ts is documentation-only.
Test Results
Build: PASS for current main core build during scheduled run
Unit tests: PASS for current main core Jest (699 passed, 3 skipped)
Server starts: NOT VERIFIED for this PR head
E2E smoke: N/A (documentation-only)
Findings
No blocking findings.
PMXT Pipeline Check
Field propagation (3-layer): N/A
OpenAPI sync: N/A
Financial precision: N/A
Type safety: N/A
Auth safety: N/A
Semver Impact
patch -- documentation/spec-comment cleanup only.
Risk
I did not perform an external SuiBets spec fetch; this review only verifies the PR is documentation-only in this repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1356.
Issue #1356 reported that the SuiBets
GET /api/events/upcomingendpoint was returning a400 Bad Request.Upon auditing the runtime logic, I found that
fetchRawEventswas already successfully refactored to synthesize events from/api/p2p/offersinstead of using the broken endpoint. However, the legacy endpoint was left dangling in theapi.tsdocumentation, leading to the open issue.This PR simply removes the deprecated endpoint from the documentation to align it with the current implementation and safely closes the stale issue.