fix(skills): handle HDR video outro inputs#89
Draft
doodlewind wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The CSV ffprobe output used by the script can append an empty field for streams with HDR side data, so values such as
1920arrived as1920,and failed numeric parsing. After that parsing issue was bypassed, the graph still mixed sRGB card pixels directly into HLG code values and emitted 8-bit H.264 tagged as HLG, which made the end card colorimetrically incorrect on HDR-aware displays and fragile on common sharing targets.Impact
Phone footage recorded as HLG/PQ now produces a broadly compatible BT.709 SDR end card video. SDR inputs retain the existing path. HDR inputs on older FFmpeg builds fail with a clear FFmpeg 8+ requirement instead of silently producing a mislabeled result.
Validation
ffmpeg -xerrorbt709/bt709/bt709, H.264 High, yuv420p, AAC stereo, and faststartbun build skills/pocketjs-video-outro/scripts/make-outro.ts --target=bungit diff --check