Skip to content

fix(Foundation): TaskManagerTest::testCancel waits for the progress notification #5607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aleks-f merged 2 commits into from
Oct 29, 2026
Merged

fix(Foundation): TaskManagerTest::testCancel waits for the progress notification #5607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab662fc
fix(Foundation): TaskManagerTest::testCancel waits for the progress n…
aleks-f Oct 29, 2026
e8854c5
chore(Foundation): stop ignoring TaskManagerTest::testCancel on Windows
aleks-f Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Foundation/testsuite/src/TaskManagerTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ void TaskManagerTest::testCancel()
assertTrue (pTT->progress() == 0);
Thread::sleep(200);
pTT->cont();
assertTrue (waitForCondition([&]{ return pTT->progress() == 0.5f; }, 5000));
assertTrue (waitForCondition([&]{ return to.progress() > 0; }, 5000));
assertTrue (to.progress() == 0.5);
assertTrue (to.started());
assertTrue (pTT->state() == Task::TASK_RUNNING);
Expand Down
1 change: 0 additions & 1 deletion cppignore.win
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,3 @@ class CppUnit::TestCaller<class SyslogTest>.testChannelFacility
class CppUnit::TestCaller<class SyslogTest>.testChannelOpenClose
class CppUnit::TestCaller<class SyslogTest>.testOldBSD
class CppUnit::TestCaller<class SyslogTest>.testStructuredData
class CppUnit::TestCaller<class TaskManagerTest>.testCancel
Loading