Repository navigation
Fix formula: rework as sdist/wheel hybrid - #3
Merged
Merged
Conversation
Homebrew's Language::Python::Virtualenv#pip_install always invokes pip with --no-binary=:all:, and only special-cases wheels tagged exactly *-py3-none-any.whl (installed by direct file path, bypassing the flag). Any other wheel gets staged as a directory and pip fails with "Neither 'setup.py' nor 'pyproject.toml' found" -- confirmed by PR #2's CI failing on bsdiff4's manylinux wheel. Rework the formula as a hybrid: pure-Python packages keep their py3-none-any wheel (fast, no compile); the 25 packages with native extensions (cryptography, pydantic-core, orjson, pillow, etc.) go back to sdist and build from source, restoring the rust/freetype/ jpeg-turbo build dependencies. quickjs-rs keeps its wheel since it bundles its own .wasm payloads (self-contained); wasmtime goes back to sdist since its "any" wheel is just ctypes bindings with no bundled native library. sqlite-vec (no sdist, no universal wheel) is excluded from virtualenv_install_with_resources and staged/ installed manually in `install` instead, since Homebrew's resource mechanism has no path that works for it at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bsdiff4: Homebrew'spip_installalways passes--no-binary=:all:to pip, and only special-cases wheels tagged exactly*-py3-none-any.whl(installs that file directly). Any other wheel (i.e. every platform-specific wheel a compiled package ships) gets staged as a directory, and pip fails since a wheel has nosetup.py/pyproject.toml.Formula/dcode.rbas a hybrid: pure-Python packages keep theirpy3-none-anywheel; the 25 packages with native extensions (cryptography,pydantic-core,orjson,pillow, etc.) go back to sdist and build from source, restoringrust/freetype/jpeg-turboas build dependencies.quickjs-rskeeps its wheel (bundles its own.wasmpayloads, genuinely self-contained).wasmtimegoes back to sdist (itsanywheel is ctypes-only, no bundled native lib).sqlite-vec(no sdist, no universal wheel) is excluded fromvirtualenv_install_with_resourcesand staged/installed manually.--no-binary=:all:constraint.Test plan
ruby -c Formula/dcode.rb— syntax check passesmainGenerated by Claude Code