make rectify add checksums when they are not there yet - #406
Merged
Merged
Conversation
nevrome
added this pull request to stack #407
September 26, 2026 16:56
Member
Author
|
Continuing the discussion from #401 I now think that rectify should indeed just add missing checksums. It's easier, overall. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rectifyModifySplit #406 +/- ##
======================================================
+ Coverage 52.48% 52.53% +0.04%
======================================================
Files 38 38
Lines 6127 6129 +2
Branches 655 654 -1
======================================================
+ Hits 3216 3220 +4
+ Misses 2256 2255 -1
+ Partials 655 654 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stschiff
approved these changes
Sep 28, 2026
stschiff
left a comment
stschiff
left a comment
Member
There was a problem hiding this comment.
Nice! Please merge, I'll review all of this again in rectifyModifySplit before merging into master.
nevrome
force-pushed
the
rectifyAddChecksums
branch
from
September 29, 2026 09:10
a2a11da to
f58aa7d
Compare
nevrome
removed this pull request from stack #407
September 29, 2026 11:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.