Skip to content

count SNPs in modify - #408

Open
nevrome wants to merge 5 commits into
rectifyModifySplitfrom
modifyNrSNPs
Open

nevrome wants to merge 5 commits into
rectifyModifySplitfrom
modifyNrSNPs

Conversation

@nevrome

@nevrome nevrome commented Sep 26, 2026

Copy link
Copy Markdown
Member

Closes #298 when merged.

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.52174% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.55%. Comparing base (c4e87bc) to head (68b58a5).

Files with missing lines Patch % Lines
src/Poseidon/CLI/Trident/Modify.hs 61.90% 8 Missing and 8 partials ⚠️
...Poseidon/CLI/Trident/OptparseApplicativeParsers.hs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           rectifyModifySplit     #408      +/-   ##
======================================================
+ Coverage               52.53%   52.55%   +0.01%     
======================================================
  Files                      38       38              
  Lines                    6129     6165      +36     
  Branches                  654      661       +7     
======================================================
+ Hits                     3220     3240      +20     
- Misses                   2255     2264       +9     
- Partials                  654      661       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nevrome
nevrome marked this pull request as ready for review September 27, 2026 15:30
@nevrome
nevrome requested a review from stschiff September 27, 2026 15:30

@stschiff stschiff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for implementing this, very useful! You haven't added a golden test, which is fine... have you tested it yourself?

@nevrome

nevrome commented Sep 29, 2026

Copy link
Copy Markdown
Member Author

I tried it in the community-archive, yes, and also added a basic golden test now.

Could you quickly confirm that my use of getJointGenotypeData is approrpiate, and that there is no chance that the order of counts would not match the order of samples in the .janno file? My implementation is so simple that I'm worrying about missing something here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants