Skip to content

DOI validation as suggested in #398 - #409

Merged
nevrome merged 6 commits into
masterfrom
doiValidation
Oct 5, 2026
Merged

nevrome merged 6 commits into
masterfrom
doiValidation

Conversation

@nevrome

@nevrome nevrome commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

When merged this should solve #398.

With these changes validating the community-archive yields this output:

[Info]    Validating: .
[Info]    Checking base directories...
[Info]    Searching POSEIDON.yml files...
[Info]    213 found
[Info]    Checking Poseidon versions...
[Info]    Initializing packages...
[Warning] The .ssf file in the package 2024_Gretzinger_Oakhurst features Poseidon_IDs that are not in the package: OAK004.B
[Warning] In file 2026_Ghalichi_IAEliteNomads/2026_Ghalichi_IAEliteNomads.bib in entry GhalichiSciAdv2026: DOI looks suspicious and may not be valid (10.XXXX/ExampleJournal.47.777)
[Warning] In file 2024_Ghalichi_Caucasus/2024_Ghalichi_Caucasus.bib in entry WangNatureCommunications2019: No DOI
[Warning] In file 2016_Mallick_SGDP1240K_diploid_pulldown/LITERATURE.bib in entry MeyerScience2012: No DOI
[Warning] Value anomaly in ./2020_Ning_China/ENAtable.ssf in line 39:
[Warning] read_count is set to -1, which indicates a missing value.
[Warning] In file 2021_PattersonNature/sources.bib in entry LipsonNature2017: No DOI
[Warning] In file 2021_PattersonNature/sources.bib in entry MathiesonNature2015: No DOI
[Warning] In file 2021_PattersonNature/sources.bib in entry MathiesonNature2018: No DOI
[Warning] In file 2021_PattersonNature/sources.bib in entry NarasimhanPattersonScience2019: No DOI
[Warning] In file 2021_PattersonNature/sources.bib in entry OlaldeNature2018: No DOI
[Warning] In file 2021_PattersonNature/sources.bib in entry OlaldeScience2019: No DOI
[Warning] In file 2021_PattersonNature/sources.bib in entry HarneyCheronetGenomeResearch2021: No DOI
[Warning] The .ssf file in the package 2021_Yaka_Anatolia features Poseidon_IDs that are not in the package: Ash033.SG
[Info]    Packages loaded: 213
[Warning] For packages below Poseidon v3.0.0 (poseidonVersion) values in the .janno columns Endogenous and Damage were rescaled from percent (0-100) to fractions (0-1).
[Info]    Validation passed

@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.48%. Comparing base (58d10f8) to head (ba694ec).

Files with missing lines Patch % Lines
src/Poseidon/Core/BibFile.hs 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
+ Coverage   52.36%   52.48%   +0.12%     
==========================================
  Files          37       37              
  Lines        6065     6085      +20     
  Branches      648      649       +1     
==========================================
+ Hits         3176     3194      +18     
- Misses       2241     2242       +1     
- Partials      648      649       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stschiff stschiff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this. I'm not following everything, see comments, but I also trust you, and my confusion relates only to the golden tests... so good to merge as I'm sure you know what you're doing.

Comment thread src/Poseidon/Core/BibFile.hs
Comment thread test/PoseidonGoldenTests/GoldenTestData/validate/validate1
Comment thread test/PoseidonGoldenTests/GoldenTestsRunCommands.hs
@nevrome
nevrome merged commit 3ade385 into master Oct 5, 2026
3 of 4 checks passed
@nevrome
nevrome deleted the doiValidation branch October 5, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants