Skip to content

Only trigger Claude conditional prompting for 5.0 and 5.1 models - #403

Merged
skaltman merged 3 commits into
mainfrom
claude-5-prompting
Oct 8, 2026
Merged

skaltman merged 3 commits into
mainfrom
claude-5-prompting

Conversation

@skaltman

@skaltman skaltman commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Closes #399

Updates the conditional prompting about brevity to only trigger for Claude 5.0 and 5.1 models, instead of all Claude 5.x models.

Adds a skip_on_cran() test that begins failing on 2027-04-06 (6 months from now), as a reminder to remove this conditional prompting entirely once the Claude 5/5.1 models are no longer recent.

@skaltman
skaltman requested a review from simonpcouch October 7, 2026 22:08
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployed to Connect (dogfood.team.pct.posit.it): https://dogfood.team.pct.posit.it/connect/#/apps/d7a36cae-8f27-448b-a478-61b81fbe3942/draft/378009

Deployed from commit dcde5b0.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Preview root: https://posit-dev.github.io/commons/pr-403/

Python site preview: https://posit-dev.github.io/commons/pr-403/py/

Built from the latest commit on this branch. The R links in it point at the published R site, which no pull request rebuilds.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployed to Connect (connect.staging.pct.posit.it): https://connect.staging.pct.posit.it/connect/#/apps/ad662e1b-5048-4acc-9ad7-f9478c92274e/draft/3405

Deployed from commit dcde5b0.

@simonpcouch simonpcouch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread pkg-r/R/prompt.R Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should be renaming this (and similarly in Python) now that we know that Claude 5.5+ is fine. Hard to come up with a Claude-only name, but could be needs_brevity_prompting() or something (with a comment about the Claude 5.0 and 5.1 saga). Will leave it up to you whether this ought to happen.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can rename! It's now confusing.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-requesting review because it changed so many files

@skaltman
skaltman requested a review from simonpcouch October 8, 2026 17:23
@skaltman
skaltman merged commit eaf0bc1 into main Oct 8, 2026
23 checks passed
@skaltman
skaltman deleted the claude-5-prompting branch October 8, 2026 18:38
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Cleaned up 2 preview bundle(s) on https://dogfood.team.pct.posit.it: 377641, 378009

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Cleaned up 2 preview bundle(s) on https://connect.staging.pct.posit.it: 3388, 3405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the Claude-5-specific prompting

2 participants