Repository navigation
fix: report incompatible types in comparison steps as evaluation errors - #459
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparison steps (
col_vals_gt/ge/lt/le/eq/ne,col_vals_between/outside) now check, before comparing, that the column and the value or other column have compatible types. A mismatch gives an evaluation error with a note, as does a column type the method can't check. Before, these crashedinterrogate()on Polars LazyFrames, DuckDB/Ibis and PySpark, or quietly gave wrong results on pandas and Polars. Date strings against date columns, and integers against floats, still work.