Repository navigation
fix: align SDTMIG 3.4 presence and not-null rules with the IG’s core designations - #464
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, presence rules now require only Required and Expected variables, and not-null rules apply only to Required variables, matching the SDTMIG 3.4 core designations. 52 rules that flagged conformant data were removed, for example a missing ETHNIC or EXROUTE, or a null LBORRES on a "not done" record, along with rules on variables SDTMIG doesn't define (such as TASEQ) (362 rules remain).
A test now checks every presence and not-null rule against a fixture of SDTMIG 3.4 core designations, and the conformant test package includes a "not done" lab record.