Repository navigation
gzip result files - #65
Merged
Merged
Conversation
rkaminsk
force-pushed
the
feature/gzip
branch
from
September 6, 2026 06:19
0b0318a to
b9407d3
Compare
rkaminsk
force-pushed
the
feature/gzip
branch
from
September 6, 2026 19:11
b9407d3 to
e9e84ef
Compare
tzschmidt
approved these changes
Sep 8, 2026
Member
Author
|
I think, I would just write a separate open function: def my_open(path, file_name):
path = os.path.join(path, file_name)
gz_path = path + ".gz"
if os.path.isfile(gz_path):
return gzip.open(gz_path, errors="ignore", encoding="utf-8", mode="rt")
return open(path, errors="ignore", encoding="utf-8", mode="rt") |
Member
Author
|
Maybe we should also make the gzip version the default in the templates and examples because it might safe a lot of disk space. |
Collaborator
|
I think we should keep the non gzip version as the default for now. I had the experience, that most people get to know the tool using smaller examples, where they want to manually inspect the result files. |
Member
Author
|
I just thought it would be the safer default. Since we had space trouble on the cluster in the past (where the tool is primarily used), this might improve the situation. I won't fight for making it the default though. Just my two cents. |
Collaborator
|
I will keep it in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have a benchmark which were generating huge output files due to large models. What do you think about gzipping output files? Maybe one could still make this optional: provide to templates, one that gzips and one that does not. The resultparser could then simple use whatever is available the gzipped or the uncompressed version. Warning I did not test it yet.