Skip to content

gzip result files - #65

Merged
tzschmidt merged 3 commits into
masterfrom
feature/gzip
Sep 8, 2026
Merged

tzschmidt merged 3 commits into
masterfrom
feature/gzip

Conversation

@rkaminsk

@rkaminsk rkaminsk commented Sep 5, 2026

Copy link
Copy Markdown
Member

Hi, I have a benchmark which were generating huge output files due to large models. What do you think about gzipping output files? Maybe one could still make this optional: provide to templates, one that gzips and one that does not. The resultparser could then simple use whatever is available the gzipped or the uncompressed version. Warning I did not test it yet.

@rkaminsk

rkaminsk commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

I think, I would just write a separate open function:

def my_open(path, file_name):
    path = os.path.join(path, file_name)
    gz_path = path + ".gz"
    if os.path.isfile(gz_path):
        return gzip.open(gz_path, errors="ignore", encoding="utf-8", mode="rt")
    return open(path, errors="ignore", encoding="utf-8", mode="rt")

@rkaminsk

rkaminsk commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

Maybe we should also make the gzip version the default in the templates and examples because it might safe a lot of disk space.

@tzschmidt

tzschmidt commented Sep 8, 2026 •

Copy link
Copy Markdown
Collaborator

I think we should keep the non gzip version as the default for now. I had the experience, that most people get to know the tool using smaller examples, where they want to manually inspect the result files.
Once someone is familiar with the tool, it shouldn't be an issue for them to change the used template.

@rkaminsk

rkaminsk commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

I just thought it would be the safer default. Since we had space trouble on the cluster in the past (where the tool is primarily used), this might improve the situation. I won't fight for making it the default though. Just my two cents.

@tzschmidt

Copy link
Copy Markdown
Collaborator

I will keep it in mind.

@tzschmidt
tzschmidt merged commit 110dd52 into master Sep 8, 2026
1 check passed
@rkaminsk
rkaminsk deleted the feature/gzip branch September 8, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants