pppd: Guard writes to nak_buffer in lcp_reqci - #623
Open
paulusmack wants to merge 1 commit into
Open
Conversation
This adds a check in the main loop in lcp_reqci() to ensure that it doesn't overrun nak_buffer. This could have possibly happened before duplicate CIs were ignored, but now should not be possible. This adds the check anyway just to be completely sure. If nak_buffer gets filled to the point where there is not enough room for another NAK, we reject the current CI. Any CI being rejected then causes the nakp pointer to be reset each time around the loop so there is no further possibility of overflow. Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a check in the main loop in lcp_reqci() to ensure that it doesn't overrun nak_buffer. This could have possibly happened before duplicate CIs were ignored, but now should not be possible. This adds the check anyway just to be completely sure. If nak_buffer gets filled to the point where there is not enough room for another NAK, we reject the current CI. Any CI being rejected then causes the nakp pointer to be reset each time around the loop so there is no further possibility of overflow.