Repository navigation
NoBid Bid Adapter: forward ortb2Imp and preserve special characters in payload - version 1.4.2 - #15897
NoBid Bid Adapter: forward ortb2Imp and preserve special characters in payload - version 1.4.2#15897redaguermas wants to merge 2 commits into
Conversation
…n payload Forward each ad unit's ortb2Imp to the NoBid endpoint so impression-level first-party data reaches the server, including the GPID (ortb2Imp.ext.gpid).
…id-version-1.4.2
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d7d64e3b3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ad_type: adType, | ||
| params: bid.params, | ||
| floor: floor, | ||
| ortb2Imp: bid.ortb2Imp, |
There was a problem hiding this comment.
When publishers load this 1.4.2 change, the new ortb2Imp behavior is active but the module still assigns window.nobidVersion = '1.3.4' at line 20. Consumers and support tooling that identify the loaded NoBid adapter through this exposed global therefore continue to report the previous release, so update the constant to 1.4.2 as part of this change.
Useful? React with 👍 / 👎.
| var filterAdUnitsByIds = function(divIds, adUnits) { | ||
| var filtered = []; | ||
| if (!divIds.length) { | ||
| filtered = adUnits; |
There was a problem hiding this comment.
It seems your coverage issues are quite substantial, can you add fixes for those on this pr amd address codex feedback
Type of change
Description of change
Forward each ad unit's ortb2Imp to the NoBid endpoint so impression-level
first-party data, including the GPID (ortb2Imp.ext.gpid), reaches the server.
The payload previously stripped ', & and #, which corrupted values such as
GPIDs ("/1234/home#div-1" arrived as "/1234/homediv-1"). These characters are
now JSON unicode-escaped, so the body still contains no raw ', & or #, but
values decode intact.
Tests added for ortb2Imp forwarding, its omission when absent, and the escaping.