Repository navigation
SemantIQ RTD Provider: drop falsy company ids - #15899
Merged
patmmccann merged 1 commit intoOct 29, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:
The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers. |
patmmccann
reviewed
Oct 29, 2026
|
|
||
| const data: unknown = JSON.parse(responseText); | ||
|
|
||
| if (!isSemantiqKeywords(data)) { |
Collaborator
There was a problem hiding this comment.
Please no throws, use logError
Contributor
Author
There was a problem hiding this comment.
@patmmccann replaced, thanks for pointing that out!
patmmccann
requested changes
Oct 29, 2026
Send only real company ids, or the Audienzz id when none remain.
alexandr-kim-vl
force-pushed
the
fix/semantiq-rtd-company-ids
branch
from
October 29, 2026 11:04
cacf2e2 to
4681ced
Compare
patmmccann
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Send only real company ids, or the Audienzz id when none remain.