feat(mul): add video, multiformat, FPD, and schain support by pranavdhawan · Pull Request #15900 · prebid/Prebid.js

pranavdhawan · 2026-10-29T06:52:31Z

Type of change

Feature
Updated bidder adapter
Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Enhance the MonetiseUp (mul) bidder adapter to support:

Video Media Type: Added VIDEO support with full parameter extraction (playerSize, context, mimes, protocols, minduration, maxduration, playbackmethod, api, startdelay, skip, etc.).
Video Response Handling: Interprets vastUrl and vastXml payloads alongside banner HTML.
Multi-Format Support: Handles hybrid ad units bidding on both banner and video (will-bid-on-any).
First Party Data (FPD): Passes ortb2.site, ortb2.device, eids, schain, and ortb2Imp.ext.gpid.
Floor Pricing: Upgraded getFloor logic to query floors across banner and video formats.

Unit tests added covering video serialization, vast responses, FPD, and multi-format requests. All 13 unit tests pass and linting is clean.

Test parameters:

{
  bidder: 'mul',
  params: {
    placementId: 'test-placement-123'
  }
}

chatgpt-codex-connector · 2026-10-29T06:52:41Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-29T07:02:35.529130Z	`98ea59b`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 98ea59bb96

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-10-29T07:02:32Z

+      let floor = 0;
+      let floorCurrency = 'USD';
+      if (typeof bid.getFloor === 'function') {
+        const queryMediaType = videoMedia && !bannerMedia ? VIDEO : (bannerMedia ? BANNER : '*');


Preserve per-format floors on hybrid bids

🤖 This comment was written by an AI agent (GPT-5.6 Sol) on behalf of the requester.

When one bid contains both banner and video and the publisher defines different floor rules, this ternary always calls getFloor with banner because bannerMedia exists. The single result is then applied to both formats, so a higher banner floor suppresses video bids that meet their own floor, while a lower banner floor causes video responses below the publisher's video floor to be requested and later rejected by the floors hook. Query and represent each format's floor rather than preferentially applying banner.

AGENTS.md reference: AGENTS.md:L115-L115

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-10-29T07:02:32Z

+          skipafter: videoMedia.skipafter,
+          placement: videoMedia.placement,
+          plcmt: videoMedia.plcmt,
+          linearity: videoMedia.linearity


Preserve all validated OpenRTB video fields

🤖 This comment was written by an AI agent (GPT-5.6 Sol) on behalf of the requester.

When a newly supported video ad unit supplies core-valid fields such as battr, pos, minbitrate, or maxbitrate, this hand-built object stops at linearity and silently drops them before MonetiseUp sees the request. Blocked creative attributes, placement, and bitrate limits can therefore be ignored; populate the object from the validated properties exposed by ORTB_VIDEO_PARAMS (plus the custom context/player-size fields) rather than maintaining this partial list.

AGENTS.md reference: AGENTS.md:L92-L96

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-10-29T07:02:32Z

+      if (bid.ortb2Imp?.ext?.gpid) {
+        bidItem.gpid = bid.ortb2Imp.ext.gpid;


Forward the interstitial FPD flag

🤖 This comment was written by an AI agent (GPT-5.6 Sol) on behalf of the requester.

When a publisher sets bid.ortb2Imp.instl = 1, this new impression-level FPD handling copies only ext.gpid, so the endpoint receives no interstitial flag. MonetiseUp can consequently classify fullscreen/interstitial inventory as an ordinary banner or video placement and return unsuitable demand; forward ortb2Imp.instl on the corresponding bid item.

AGENTS.md reference: AGENTS.md:L101-L101

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-10-29T07:02:32Z

-      });
+      };
+
+      if (isVideo) {


Attach a renderer for advertised outstream bids

🤖 This comment was written by an AI agent (GPT-5.6 Sol) on behalf of the requester.

For an ad unit with context: 'outstream' that does not supply its own renderer or useCacheKey, this branch adds only VAST fields and never a renderer. checkVideoBidSetup in src/video.ts rejects exactly that case, so MonetiseUp outstream responses are discarded even though the adapter now advertises outstream support; attach a renderer or explicitly document and enforce the publisher-renderer requirement.

Useful? React with 👍 / 👎.

barecheck · 2026-10-29T07:05:04Z

Barecheck - Code coverage report

Total: 91.75%

Your code coverage diff: 0.01% ▴

Uncovered files and lines

File	Lines
modules/mulBidAdapter.ts	162, 168, 171, 240

github-actions · 2026-10-29T08:46:51Z

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

Changes to modules/mulBidAdapter.ts may need:
- es.iterator.find
- esnext.iterator.find

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

pranavdhawan · 2026-10-29T08:50:20Z

Addressed both review suggestions:

bid.ortb2Imp.instl is now forwarded in buildRequests.
Enforced publisher-renderer requirement in isBidRequestValid for outstream video when neither a renderer nor useCacheKey is provided, and documented the requirement in the module md and docs page.
Added unit tests for both cases (all 17 tests passing).

feat(mul): add video, multiformat, FPD, schain, and floors support

98ea59b

Copilot AI balanced review requested due to automatic review settings October 29, 2026 06:52

Copilot AI reviewed Oct 29, 2026

pranavdhawan mentioned this pull request Oct 29, 2026

docs(mul): document video, multiformat, FPD, and user sync support prebid/prebid.github.io#6886

Open

1 task done

review-assignment-bot Bot requested a review from lksharma October 29, 2026 06:55

chatgpt-codex-connector Bot reviewed Oct 29, 2026

View reviewed changes

fix(mul): forward instl flag and enforce outstream renderer requirement

af76ba8

Navigation Menu

Repository navigation

feat(mul): add video, multiformat, FPD, and schain support - #15900

feat(mul): add video, multiformat, FPD, and schain support#15900
pranavdhawan wants to merge 2 commits into
prebid:masterfrom
pranavdhawan:feat/mul-video-support

pranavdhawan commented Oct 29, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 29, 2026

Uh oh!

chatgpt-codex-connector Bot Oct 29, 2026

Uh oh!

chatgpt-codex-connector Bot Oct 29, 2026

Uh oh!

chatgpt-codex-connector Bot Oct 29, 2026

Uh oh!

barecheck Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 29, 2026

Uh oh!

pranavdhawan commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		if (bid.ortb2Imp?.ext?.gpid) {
		bidItem.gpid = bid.ortb2Imp.ext.gpid;

Conversation

pranavdhawan commented Oct 29, 2026

Type of change

Description of change

Uh oh!

chatgpt-codex-connector Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 29, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 29, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 29, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 29, 2026

Choose a reason for hiding this comment

Uh oh!

barecheck Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Barecheck - Code coverage report

Uh oh!

github-actions Bot commented Oct 29, 2026

Uh oh!

pranavdhawan commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chatgpt-codex-connector Bot commented Oct 29, 2026 •

edited

Loading

barecheck Bot commented Oct 29, 2026 •

edited

Loading