Repository navigation
Conversation
Code coverage summaryNote:
flippRefer here for heat map coverage report |
mike-lei
changed the title
Flipp's Mobile Swipe format can be requested per placement via
options.mobileSwipe, which our ad service now accepts. The option
cannot reach it through this adapter today: ImpExtFlippOptions is a
typed struct and jsonutil.Unmarshal is non-strict, so an unknown key in
imp.ext.bidder.options is silently discarded and the struct is
re-marshalled into the outgoing body without it:
in: {"startCompact":true,"mobileSwipe":true}
out: {"startCompact":true}
static/bidder-params/flipp.json does not set additionalProperties to
false, so the param passes schema validation first and then vanishes.
A publisher sets it, receives no error, and nothing happens.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mike-lei
force-pushed
the
flipp-mobile-swipe-option
branch
from
August 27, 2026 04:22
a6cc9f7 to
06eaaf9
Compare
Code coverage summaryNote:
flippRefer here for heat map coverage report |
przemkaczmarek
approved these changes
Sep 1, 2026
Contributor
Author
|
Thanks @przemkaczmarek for taking care of this PR! Do you know when we will merge this into master? Thanks! |
Contributor
|
Looks good. Could you open a docs PR adding Do not forget upgrade your branch: |
2 tasks done
Contributor
Author
Thanks! Docs PR is up: prebid/prebid.github.io#6796. I’ll update the branch with master as well. |
Code coverage summaryNote:
flippRefer here for heat map coverage report |
postindustria-code
approved these changes
Oct 19, 2026
postindustria-code
approved these changes
Oct 19, 2026
Code coverage summaryNote:
flippRefer here for heat map coverage report |
Code coverage summaryNote:
flippRefer here for heat map coverage report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
mobileSwipeto the Flipp adapter'soptionsbidder param, so publishers can request Flipp's Mobile Swipe format per placement.The key cannot reach our endpoint today:
ImpExtFlippOptionsis a typed struct andjsonutil.Unmarshalis non-strict, so it is dropped without an error and the struct is re-marshalled into the outgoing request without it.Adds the struct field, the schema property, param tests, and an exemplary case covering the forwarding. No change to the outgoing body when the option is absent.
🤖 Generated with Claude Code