Repository navigation
Conversation
|
|
||
| // Get media type from the bid's mtype, which the Nativo exchange sets on every bid | ||
| func getMediaTypeForMType(mType openrtb2.MarkupType) (openrtb_ext.BidType, error) { | ||
| switch mType { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeAudio. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
|
|
||
| // Get media type from the bid's mtype, which the Nativo exchange sets on every bid | ||
| func getMediaTypeForMType(mType openrtb2.MarkupType) (openrtb_ext.BidType, error) { | ||
| switch mType { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
|
|
||
| // Get media type from the bid's mtype, which the Nativo exchange sets on every bid | ||
| func getMediaTypeForMType(mType openrtb2.MarkupType) (openrtb_ext.BidType, error) { | ||
| switch mType { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
|
|
||
| // Get media type from the bid's mtype, which the Nativo exchange sets on every bid | ||
| func getMediaTypeForMType(mType openrtb2.MarkupType) (openrtb_ext.BidType, error) { | ||
| switch mType { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
Code coverage summaryNote:
nativoRefer here for heat map coverage report |
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check