Skip to content

ci: forward runner arguments #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshblack merged 2 commits into from
Sep 4, 2026
Merged

ci: forward runner arguments #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dffc792
fix: forward runner arguments
joshblack Sep 4, 2026
58b2851
chore: merge main into runner argument fix
joshblack Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions script/run-benchmark.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,19 @@ set -euo pipefail

repository_root="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"

if [[ $# -lt 1 || $# -gt 2 ]]; then
echo "Usage: $0 <benchmark-name> [run|plan|shard|merge]" >&2
if [[ $# -lt 1 ]]; then
echo "Usage: $0 <benchmark-name> [run|plan|shard|merge] [agent-eval-options...]" >&2
exit 1
fi

benchmark_name="$1"
mode="${2:-run}"
shift
mode="run"
if [[ $# -gt 0 && "$1" != --* ]]; then
mode="$1"
shift
fi
Comment on lines +14 to +18

run_date="${RUN_DATE:-$(date -u +%F)}"
run_directory="$repository_root/results/benchmarks/$benchmark_name/$run_date"
plan_path="$run_directory/plan.json"
Expand All @@ -32,14 +39,16 @@ case "$mode" in
--concurrency "${CONCURRENCY:-1}" \
--docker-image "${DOCKER_IMAGE:-node:26.5.0-slim}" \
--output-dir "$run_directory" \
--scenarios "$repository_root/scenarios"
--scenarios "$repository_root/scenarios" \
"$@"
;;
plan)
node "$repository_root/packages/agent-eval/bin/agent-eval" \
--benchmark "$benchmark_name" \
--benchmarks "$repository_root/benchmarks" \
--plan "$plan_path" \
--scenarios "$repository_root/scenarios"
--scenarios "$repository_root/scenarios" \
"$@"
;;
shard)
if [[ ! "${SHARD:-}" =~ ^([1-9][0-9]*)/([1-9][0-9]*)$ ]]; then
Expand All @@ -54,12 +63,14 @@ case "$mode" in
--from-plan "$plan_path" \
--output-dir "$run_directory" \
--scenarios "$repository_root/scenarios" \
--shard "$SHARD"
--shard "$SHARD" \
"$@"
;;
merge)
node "$repository_root/packages/agent-eval/bin/agent-eval" \
--merge-results \
--output-dir "$run_directory"
--output-dir "$run_directory" \
"$@"
rm -f "$run_directory"/output-*.json
;;
*)
Expand Down
24 changes: 17 additions & 7 deletions script/run-experiment.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,19 @@ set -euo pipefail

repository_root="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"

if [[ $# -lt 1 || $# -gt 2 ]]; then
echo "Usage: $0 <experiment-name> [run|plan|shard|merge]" >&2
if [[ $# -lt 1 ]]; then
echo "Usage: $0 <experiment-name> [run|plan|shard|merge] [agent-eval-options...]" >&2
exit 1
fi

experiment_name="$1"
mode="${2:-run}"
shift
mode="run"
if [[ $# -gt 0 && "$1" != --* ]]; then
mode="$1"
shift
fi
Comment on lines +14 to +18

run_date="${RUN_DATE:-$(date -u +%F)}"
run_directory="$repository_root/results/experiments/$experiment_name/$run_date"
plan_path="$run_directory/plan.json"
Expand All @@ -33,14 +39,16 @@ case "$mode" in
--concurrency "${CONCURRENCY:-1}" \
--docker-image "${DOCKER_IMAGE:-node:26.5.0-slim}" \
--output-dir "$run_directory" \
--scenarios "$repository_root/scenarios"
--scenarios "$repository_root/scenarios" \
"$@"
;;
plan)
node "$repository_root/packages/agent-eval/bin/agent-eval" \
--experiment "$experiment_name" \
--experiments "$repository_root/experiments" \
--plan "$plan_path" \
--scenarios "$repository_root/scenarios"
--scenarios "$repository_root/scenarios" \
"$@"
;;
shard)
if [[ ! "${SHARD:-}" =~ ^([1-9][0-9]*)/([1-9][0-9]*)$ ]]; then
Expand All @@ -55,12 +63,14 @@ case "$mode" in
--from-plan "$plan_path" \
--output-dir "$run_directory" \
--scenarios "$repository_root/scenarios" \
--shard "$SHARD"
--shard "$SHARD" \
"$@"
;;
merge)
node "$repository_root/packages/agent-eval/bin/agent-eval" \
--merge-results \
--output-dir "$run_directory"
--output-dir "$run_directory" \
"$@"
rm -f "$run_directory"/output-*.json
;;
*)
Expand Down