-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add experiment results to the overview #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joshblack
wants to merge
4
commits into
main
Choose a base branch
from
add-experiment-results-overview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8656951
feat: add experiment results to the overview
joshblack 61248d8
fix: address experiment results review feedback
joshblack 6259a76
fix: make scenario result anchors consistent
joshblack 6cb0076
fix: align root markup with focus-visible hydration
joshblack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,198 @@ | ||
| 'use client' | ||
|
|
||
| import {Blankslate, DataTable, Table} from '@primer/react/experimental' | ||
| import type {Route} from 'next' | ||
| import {useId} from 'react' | ||
| import type {ExperimentResults, TreatmentResult} from '../../experiment-results' | ||
| import {Link} from '../../components/Link' | ||
| import {getScenarioAnchor} from '../../scenario-anchor' | ||
|
|
||
| type ExperimentSummary = { | ||
| id: string | ||
| name: string | ||
| description: string | ||
| date: string | null | ||
| treatments: Array<TreatmentResult> | ||
| } | ||
|
|
||
| function formatNumber(value: number): string { | ||
| return value.toLocaleString('en-US', {maximumFractionDigits: 1}) | ||
| } | ||
|
|
||
| function TreatmentResultsTable({results, label}: {results: Array<TreatmentResult>; label: string}) { | ||
| const labelId = useId() | ||
| return ( | ||
| <Table.Container> | ||
| <span className="sr-only" id={labelId}> | ||
| {label} | ||
| </span> | ||
| <DataTable | ||
| aria-labelledby={labelId} | ||
| cellPadding="condensed" | ||
| columns={[ | ||
| {id: 'treatment', header: 'Treatment', field: 'treatment', rowHeader: true}, | ||
| {id: 'model', header: 'Model', field: 'model'}, | ||
| {id: 'effort', header: 'Effort', field: 'reasoningEffort'}, | ||
| {id: 'trials', header: 'Trials', field: 'trials', align: 'end'}, | ||
| {id: 'scenarios', header: 'Scenarios', field: 'scenarios', align: 'end'}, | ||
| { | ||
| id: 'tests', | ||
| header: 'Tests passed', | ||
| field: 'passedTests', | ||
| align: 'end', | ||
| renderCell: row => { | ||
| return row.passRate === null | ||
| ? 'N/A (no tests)' | ||
| : `${row.passedTests}/${row.totalTests} (${formatNumber(row.passRate * 100)}%)` | ||
| }, | ||
| }, | ||
| { | ||
| id: 'tokens', | ||
| header: 'Output tokens', | ||
| field: 'outputTokens', | ||
| align: 'end', | ||
| renderCell: row => { | ||
| return formatNumber(row.outputTokens) | ||
| }, | ||
| }, | ||
| { | ||
| id: 'requests', | ||
| header: 'Premium requests', | ||
| field: 'premiumRequests', | ||
| align: 'end', | ||
| renderCell: row => { | ||
| return formatNumber(row.premiumRequests) | ||
| }, | ||
| }, | ||
| { | ||
| id: 'session', | ||
| header: 'Session time', | ||
| field: 'sessionDurationMs', | ||
| align: 'end', | ||
| renderCell: row => { | ||
| return `${formatNumber(row.sessionDurationMs / 1000)} s` | ||
| }, | ||
| }, | ||
| { | ||
| id: 'api', | ||
| header: 'API time', | ||
| field: 'totalApiDurationMs', | ||
| align: 'end', | ||
| renderCell: row => { | ||
| return `${formatNumber(row.totalApiDurationMs / 1000)} s` | ||
| }, | ||
| }, | ||
| ]} | ||
| data={results} | ||
| /> | ||
| </Table.Container> | ||
| ) | ||
| } | ||
|
|
||
| function MetricsDescription() { | ||
| return ( | ||
| <p className="text-muted"> | ||
| Tests passed is the sum of passed tests divided by total tests across recorded trials. Resource usage is the | ||
| average per trial. Treatments are grouped by model and reasoning effort; compare scenario and trial counts before | ||
| comparing performance. | ||
| </p> | ||
| ) | ||
| } | ||
|
|
||
| export function ExperimentsOverview({experiments}: {experiments: Array<ExperimentSummary>}) { | ||
| return ( | ||
| <section className="p-4 flex flex-col gap-4" aria-labelledby="experiments-overview-heading"> | ||
| <div className="flex items-center justify-between gap-3"> | ||
| <h2 className="text-title-medium" id="experiments-overview-heading"> | ||
| Experiments | ||
| </h2> | ||
| <Link href="/experiments">View all experiments</Link> | ||
| </div> | ||
| {experiments.length === 0 ? <p>No experiments have been configured yet.</p> : <MetricsDescription />} | ||
| {experiments.map(experiment => { | ||
| return ( | ||
| <section className="flex flex-col gap-3" key={experiment.id}> | ||
| <h3 className="text-title-small"> | ||
| <Link href={`/experiments/${experiment.id}`}>{experiment.name}</Link> | ||
| </h3> | ||
| <p>{experiment.description}</p> | ||
| {experiment.date ? ( | ||
| <p> | ||
| Latest run:{' '} | ||
| <Link href={`/experiments/${experiment.id}/runs/${experiment.date}` as Route}> | ||
| <time dateTime={experiment.date}>{experiment.date}</time> | ||
| </Link> | ||
| . <Link href={`/experiments/${experiment.id}`}>View scenario results and run history</Link> | ||
| </p> | ||
| ) : null} | ||
| {experiment.treatments.length > 0 ? ( | ||
| <TreatmentResultsTable | ||
| label={`Latest treatment results for ${experiment.name}`} | ||
| results={experiment.treatments} | ||
| /> | ||
| ) : ( | ||
| <p> | ||
| {experiment.date | ||
| ? 'No trial results were recorded in the latest run.' | ||
| : 'No results have been recorded for this experiment yet.'} | ||
| </p> | ||
| )} | ||
| </section> | ||
| ) | ||
| })} | ||
| </section> | ||
| ) | ||
| } | ||
|
|
||
| export function LatestExperimentResults({id, results}: {id: string; results: ExperimentResults | null}) { | ||
| if (!results) { | ||
| return null | ||
| } | ||
|
|
||
| return ( | ||
| <section className="flex flex-col gap-4" aria-labelledby="latest-results-heading"> | ||
| <h2 className="text-title-medium" id="latest-results-heading"> | ||
| Latest results | ||
| </h2> | ||
| <p> | ||
| Run:{' '} | ||
| <Link href={`/experiments/${id}/runs/${results.date}` as Route}> | ||
| <time dateTime={results.date}>{results.date}</time> | ||
| </Link> | ||
| </p> | ||
| {results.treatments.length > 0 ? ( | ||
| <> | ||
| <MetricsDescription /> | ||
| <TreatmentResultsTable label="Latest treatment results" results={results.treatments} /> | ||
| </> | ||
| ) : ( | ||
| <Blankslate border> | ||
| <Blankslate.Heading as="h3">No trial results</Blankslate.Heading> | ||
| <Blankslate.Description>No trial results were recorded in the latest run.</Blankslate.Description> | ||
| </Blankslate> | ||
| )} | ||
| <h3 className="text-title-small">Scenario results</h3> | ||
| {results.scenarios.map(scenario => { | ||
| return ( | ||
| <section className="flex flex-col gap-3" key={scenario.id}> | ||
| <h4 className="text-title-small">{scenario.id}</h4> | ||
| {scenario.treatments.length > 0 ? ( | ||
| <> | ||
| <TreatmentResultsTable label={`Treatment results for ${scenario.id}`} results={scenario.treatments} /> | ||
| <p> | ||
| <Link | ||
| href={`/experiments/${id}/runs/${results.date}${getScenarioAnchor(scenario.id).fragment}` as Route} | ||
| > | ||
| View output for {scenario.id} | ||
| </Link> | ||
| </p> | ||
| </> | ||
| ) : ( | ||
| <p>No trial results were recorded for this scenario.</p> | ||
| )} | ||
| </section> | ||
| ) | ||
| })} | ||
| </section> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.