Repository navigation
Release 1.46.2: nested revise reuse, no git polling in claim renewals - #293
Merged
Merged
Conversation
The regions treatment puts one builder per region in an inner map inside each group. On a follow-up, unnamed groups are reused, and inside a named group only the regions that the request names build again. The group review still covers the whole group.
Codex R196 (1.46.1, regions treatment): groups that the follow-up did not
name ran again, because _reads_request kept the inner builder's revise in
the searched text when the entry node is a map. {{prev}} now counts only in
nodes that get the request as prev: the entry, the branches of an entry
parallel, and the same nodes inside an entry map. An entry parallel branch
that reads {{prev}} now counts too. Release 1.46.2.
Each claim renewal (every ttl/3, about 0.7 s) ran two git processes for the repository identity. The second (--git-common-dir) was not used. A 4-worker probe counted 57-62 subprocesses per worker, growing with build time; after this change it is 24 and fixed.
professorpalmer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex R196 (PM 1.46.1, one builder per region inside each group, map
reuseon): groups 00 and 02 were not named by the follow-up but did not reuse ("its item graph reads the request"). Eight extra region builders ran._reads_requestremovedreviseonly from the entry node. With a map entry, the inner builder'srevise({{prev}}) stayed in the searched text.{{prev}}now counts only in nodes that get the request asprev: the entry, the branches of an entryparallel, and the same nodes inside an entrymap.parallelbranch whose task reads{{prev}}now counts. Before, it was not searched.{{input}}anywhere still counts.Tests: new unit cases and a nested follow-up reuse test. Both fail on 1.46.1 and pass here. Full suite: OK (skipped=39). On the real regions graph, 1.46.1 gives
Trueand this branch givesFalse.Second change: claim renewals no longer start git.
ttl/3, about 0.7 s) rangit rev-parse --show-topleveland an unused--git-common-dir.