fix(nntp): handle open-ended OVER range like '5-'#75
Merged
ralyodio merged 1 commit intoJul 3, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The NNTP
OVERcommand with an open-ended range like5-(meaning "all articles from 5 to end") currently returns 0 articles.Root cause:
parseRange("5-")splits on-→["5", ""].strconv.ParseInt("", 10, 64)returns an error, so the function falls through toreturn 0, 0instead of returning(5, math.MaxInt64).Fix
Check for empty
parts[1]before attempting to parse it — treat it as an open-ended range (math.MaxInt64).Related ugig gig: https://ugig.net/gigs/14eb1fad-1c95-4ba9-bd6f-5b6f9de1a664