fix(ans): reject non-hex input in fromHex instead of silently decoding to 0#91
Merged
ralyodio merged 1 commit intoJul 2, 2026
Conversation
…g to 0
fromHex validated only that the string was even-length, then used
parseInt(pair, 16) per byte. parseInt returns NaN for a non-hex pair, and a
Uint8Array stores NaN as 0 — so fromHex('zzzz') silently returned [0, 0]
instead of failing. Add a hex-charset check (allowing empty input) so bad
input throws. Add bytes.test.ts covering valid decode, round-trip, odd-length
and non-hex cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fromHex()(packages/ans/src/bytes.ts) validated only that the input was even-length, then usedparseInt(pair, 16)per byte.parseIntreturnsNaNfor a non-hex pair, and aUint8ArraystoresNaNas0— sofromHex('zzzz')silently returned[0, 0]instead of failing (see #90).Fix
Reject non-hex characters before decoding (the
*quantifier keeps empty input valid):Tests
Added
bytes.test.tscovering valid decode (with/without0x),toHex/fromHexround-trip, odd-length input, and non-hex input ('zzzz','00gg','0xnothex').Fixes #90.