fix(policy): treat malformed expiresAt as expired, not active#92
Open
forgou37 wants to merge 1 commit into
Open
fix(policy): treat malformed expiresAt as expired, not active#92forgou37 wants to merge 1 commit into
forgou37 wants to merge 1 commit into
Conversation
Date.parse() returns NaN for invalid date strings. Previously, a grant with expiresAt set to a malformed value (e.g. 'invalid') would pass the expiry check (NaN > Date.now() === false, but the falsy NaN would skip the check due to how the condition was written—or more precisely, would evaluate incorrectly). Now, if expiresAt is present but cannot be parsed, the grant is treated as expired/invalid rather than silently allowing access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where a policy grant with an invalid (NaN/null)
expiresAtvalue was treated as active instead of expired. Now falls back to treating it as already expired, which is the safe default.Found via QA testing for
/bug-fixesgig.