fix(desktop): drop misleading --metrics-recording-only=false from PRIVACY_FLAGS#22
Merged
ralyodio merged 1 commit intoJul 2, 2026
Conversation
…VACY_FLAGS PRIVACY_FLAGS is documented as flags that 'hard-disable phone-home / telemetry' and is applied by default whenever telemetry is not opted in, but '--metrics-recording-only=false' does not disable telemetry — the switch only ever governs local metrics recording, and passing it here is at best a no-op and at worst misleading given the file's stated guarantee and the project's 'No telemetry by default' rule. The actual no-telemetry posture is enforced by the other PRIVACY_FLAGS (--disable-background-networking, --disable-breakpad, --disable-crash-reporter, --no-pings, --disable-domain-reliability) plus the compile-time build config. Removing this flag strictly improves clarity and cannot weaken privacy. The dynamic-iteration test needs no change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PRIVACY_FLAGS(apps/desktop/src/chromium-flags.ts) is documented as flags that "hard-disable phone-home / telemetry" and is applied by default whenever telemetry isn't opted in, but--metrics-recording-only=falsedoes not disable telemetry — the switch only ever governs local metrics recording. Its presence contradicts the file's stated guarantee and the project's "No telemetry by default" rule (see #21).Fix
Remove the misleading
--metrics-recording-only=falseentry. The actual no-telemetry posture is enforced by the otherPRIVACY_FLAGS(--disable-background-networking,--disable-breakpad,--disable-crash-reporter,--no-pings,--disable-domain-reliability) plus the compile-time build config, so removing this flag strictly improves clarity and cannot weaken privacy.The existing test iterates
PRIVACY_FLAGSdynamically, so it needs no change.Fixes #21.