Skip to content

refactor(api): make template query methods private - #91

Merged
zhangwenjun-huawei merged 1 commit into
project-openan:mainfrom
zhangwenjun-huawei:main
Oct 26, 2026
Merged

zhangwenjun-huawei merged 1 commit into
project-openan:mainfrom
zhangwenjun-huawei:main

Conversation

@zhangwenjun-huawei

Copy link
Copy Markdown
Contributor

Description

  • rename A2ATClient/A2ATServer get_prompts/get_prompt to the private _get_prompts/_get_prompt
  • remove template queries from the public facade documentation
  • update the negotiation API tests and facade symmetry guard to assert the query methods are no longer public
  • document the two methods as SDK-internal interfaces without a cross-version compatibility guarantee in API reference 1.2

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Other (describe below)

Checklist

  • I have read the CONTRIBUTING guide
  • All commits are signed off (git commit -s) per the DCO
  • New and existing tests pass locally
  • I have added tests that prove my fix is effective or my feature works (if applicable)
  • I have added or updated documentation as needed
  • New source files include the SPDX license header

Additional Context

- rename A2ATClient/A2ATServer get_prompts/get_prompt to the private _get_prompts/_get_prompt
- remove template queries from the public facade documentation
- update the negotiation API tests and facade symmetry guard to assert the query methods are no longer public
- document the two methods as SDK-internal interfaces without a cross-version compatibility guarantee in API reference 1.2

Signed-off-by: zhangwenjun-huawei <zhangwenjun19@huawei.com>
@zhangwenjun-huawei
zhangwenjun-huawei requested a review from a team as a code owner October 26, 2026 04:07
@zhangwenjun-huawei
zhangwenjun-huawei merged commit 31a405a into project-openan:main Oct 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant