Repository navigation
fix: support classpath: prefix in AgentAuthManager credential loading - #19
Merged
Merged
Conversation
AgentAuthManager.loadFromFile() used new File(path) which does not understand the classpath: prefix. When SpringWorkbenchExecutor passed 'classpath:spn_agent_credentials.json', the file was silently not found and no credentials were loaded, resulting in missing Authorization headers. Fix: detect classpath: prefix and use ClassLoader.getResourceAsStream(). Also add warn logs for missing files (previously silent). Added 2 test cases: - loadsCredentialsFromClasspathPrefix - missingClasspathResourceDoesNotCreateCredentials Signed-off-by: Zhoujie628 <zhoujie628@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AgentAuthManager.loadFromFile()usesnew File(path)which does not understand theclasspath:prefix. WhenSpringWorkbenchExecutorpassesclasspath:spn_agent_credentials.json, the file is silently not found and no credentials are loaded.Symptom: PROTOCOL logs show
A2A-Extensionsheader but noAuthorizationheader. No[Auth]log output at all.Root Cause
SpringWorkbenchExecutor.resolveCredentialsPath()returnsclasspath:spn_agent_credentials.jsonwhen the resource exists on classpath. ButAgentAuthManager.loadFromFile()does:Fix
classpath:prefix and useClassLoader.getResourceAsStream()Changes (2 files)
AgentAuthManager.java: Add classpath: support inloadFromFile()AgentAuthManagerTest.java: Add 2 test cases for classpath: prefixTesting
mvn test -pl workflow-engine -Dtest=AgentAuthManagerTestpasses (4 tests)[Auth] Loaded credentials for N agent(s) from classpath:...log appearsCloses #18