Repository navigation
build: add Checkstyle, SpotBugs and JaCoCo quality gates - #82
Merged
Merged
Conversation
The A2A Java SDK annotates its interfaces with JSpecify @NullMarked; classes overriding those interfaces without the annotation trigger IDEA inspection warnings. Add @NullMarked to the client and spring packages via package-info.java (fully qualified annotation name to avoid import parsing issues in package-info), with jspecify as a provided-scope dependency. Also upgrade google-java-format to 1.24.0 and exclude package-info.java from spotless (google-java-format cannot parse it). Signed-off-by: Zhoujie628 <zhoujie628@users.noreply.github.com>
Three static-analysis gates join Spotless in the reactor build: - Checkstyle (validate phase): naming, complexity and structural checks. Formatting stays with Spotless; thresholds calibrated to the existing codebase with a suppressions file for accepted legacy items. - SpotBugs (verify phase, threshold Medium): bug-pattern detection with a documented exclusion filter (mutable-exposure API surface, no-serialization project, demo-code items to revisit on next touch). - JaCoCo (test phase): coverage reporting per module, no threshold gate yet. Also fix two latent items the gates surfaced: expand star imports in DefaultWorkflowEngineClient, and add JSpecify @NullMarked package-info to the client and spring packages (with jspecify as provided dependency and google-java-format 1.24.0, which handles the newer JDK APIs). Signed-off-by: Zhoujie628 <zhoujie628@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three static-analysis gates join Spotless in the reactor build:
Also fixes two latent items the gates surfaced: star imports expanded in DefaultWorkflowEngineClient, and JSpecify @NullMarked package-info added to the client and spring packages (jspecify as provided dependency, google-java-format 1.24.0, package-info excluded from Spotless parsing).