Repository navigation
refactor(model): defensively copy collection fields, expose unmodifiable views - #83
Merged
Merged
Conversation
…ble views Model types returned raw references to their internal collections, so a caller mutating a getter result silently corrupted engine-owned snapshots and could leak across concurrent executions. Collection fields on Workflow, WorkflowStep, WorkflowSearchResult, ExecutionResult, SendMessageResult, TaskResult, BusinessFailure and the message records are now copied on write and exposed through unmodifiable views. Source- and binary-compatible: no signatures change, and no call site in the reactor mutates a returned collection. Callers that do mutate getter results now receive UnsupportedOperationException instead of corrupting engine state; noted in the changelog for integrators. SpotBugs EI exclusions narrow accordingly: the blanket EI acceptance is replaced by targeted rules for Lombok-generated builders (build() performs the copies) and five documented engine-internal acceptances, so future model code with raw exposure fails the gate. Copies are null-tolerant where entries may be null, preserving graph-validation semantics covered by WorkflowExecutorTest. Signed-off-by: Zhoujie628 <zhoujie628@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model types returned raw references to their internal collections, so a caller mutating a getter result silently corrupted engine-owned snapshots and could leak across concurrent executions.
Collection fields on Workflow, WorkflowStep, WorkflowSearchResult, ExecutionResult, SendMessageResult, TaskResult, BusinessFailure and the message records are now copied on write and exposed through unmodifiable views.
Source- and binary-compatible: no signatures change, and no call site in the reactor mutates a returned collection. Callers that do mutate getter results now receive UnsupportedOperationException instead of corrupting engine state; noted in the changelog for integrators.
SpotBugs EI exclusions narrow accordingly: the blanket EI acceptance is replaced by targeted rules for Lombok-generated builders (build() performs the copies) and five documented engine-internal acceptances, so future model code with raw exposure fails the gate.