Skip to content

fix(engine): keep active notification streams alive and release them reliably - #88

Merged
Zhoujie628 merged 1 commit into
project-openan:mainfrom
hanyu0504:main
Sep 23, 2026
Merged

fix(engine): keep active notification streams alive and release them reliably#88
Zhoujie628 merged 1 commit into
project-openan:mainfrom
hanyu0504:main

Conversation

@hanyu0504

@hanyu0504 hanyu0504 commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep Notification-T streams alive while decoded A2A events or transport/SSE activity continues, fixing WAIMO's 600-second false timeout.
  • Track a monotonic idle deadline instead of fixed windows, and avoid retaining every long-lived stream event.
  • Release conversation-scoped clients on normal termination and failure; add regression tests.

Validation

  • Engine module: 244 tests passed on main and dev.
  • Full dev reactor: samples E2E tests blocked by local port-binding failures; one unrelated Order SSE warning-marker assertion also failed. Live WAIMO >10-minute verification remains pending.

No breaking API change intended. Not merged; maintainer review requested.

@hanyu0504
fix(engine): keep active notification streams alive and release them …
c8b0f48 
…reliably

Signed-off-by: hanyu0504 <zhouyulong@gdhurray.com>
@hanyu0504
hanyu0504 requested a review from a team as a code owner September 23, 2026 12:49
@Zhoujie628
Zhoujie628 merged commit 952cde2 into project-openan:main Sep 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hanyu0504 @Zhoujie628