docs: name the RPCs without a command and say where --limit applies - #128
Merged
Merged
Conversation
The README claimed every core RPC has a command; five do not. The workload list --limit help said only 'limit data size': the cap is applied by the server before the client-side pod and IP filters, so a filtered list can return fewer rows than the limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README claimed every core RPC has a command; GetPod, GetWorkload, GetNodeStatus, GetNodeEngineInfo and RawEngine do not. The
workload list --limithelp said only 'limit data size': the cap is applied by the server before the client-side --pod, --match-ip and --skip-ip filters, so a filtered list can return fewer rows than the limit. Wording only.