fix: close the cli audit items - #129
Merged
Merged
Conversation
An empty result renders the header-only table on every read command. Nodes a command already holds are described from a slice; the channel form is NodesStream and node resource has a single-item form, so no caller fabricates a channel. pod nodes --filter down filters the stream instead of buffering it, so --stream means the same for every filter. image build asks whether stdout is a terminal once. image list leaves the pod-or-node precondition to core like cache and remove. node add sends share as a number. docs/cli.md says which commands ignore --output and how --extra-resources meets a command's own flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit items E5, E6, E7, E11, E12, E13, E14 and E15.
no images, workloads and nodes no longer print nothing).describe.Nodestakes the nodes a command already holds; the channel form isNodesStream, andNodeResourcedescribes one resource, so no caller fabricates a channel (ToChanis gone from cmd).pod nodes --filter downfilters the stream (downOnly) instead of buffering the whole listing, so--streammeans the same for every filter and the up/all and down paths are one.image buildasks whether stdout is a terminal once, not per progress message.image listleaves the pod-or-node precondition to core likecacheandremovedo.node addsendsshareas a number, likecpu.--outputand how--extra-resourcesmeets a command's own flags.