perf: list nodes for the metrics scrape without their resource info - #749
Merged
Merged
Conversation
The scrape only needs each node's name and pod; the plugins read their own stores in GetNodesMetrics. Listing with resource info asked every plugin for every node on each scrape and discarded the answer, two plugin processes per scrape with the plural verb and one per node per plugin without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ListNodesOptionsgainsWithoutResourceInfo;ListPodNodesskips the plugin fan-out when it is set, and the metrics middleware lists with it. The scrape only needs each node's name and pod: the plugins read their own stores inGetNodesMetrics.Why
Listing with resource info asked every plugin for every node on each scrape and discarded the answer: two plugin processes per scrape with the plural verb, one per node per plugin without it.
Evidence
TestListPodNodespins that the manager is not called with the option set;TestResourceMiddlewareRefreshesEveryNodeInOneCallpins that the middleware passes it. Gate on the branch: build, vet, full tests,make lint,make fmt-checkandaslon both GOOS green; comment delta +0 −0; production +11 −5.