cut: drop the add-node response's usage - #750
Merged
Merged
Conversation
The field came with the 2023 plugin protocol as the pair of capacity, but cobalt reads only the capacity of a fresh node and nothing ever sent a usage other than zero. A binary plugin that still emits it is decoded without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AddNodeResponseloses itsUsagefield; cpumem stops filling it.Why
The field came with the 2023 plugin protocol as the pair of
capacity, but cobalt reads only the capacity of a fresh node (resource/cobalt/node.go), calcium stores only that, and nothing ever sent a usage other than zero. A binary plugin that still emitsusageis decoded without it, so plugin binaries built before this change keep working; resource-extend's matching PR stops sending it.Evidence
Gate on the branch: build, vet, full tests,
make lint,make fmt-checkandaslon both GOOS green; comment delta +0 −0; production −4.