Fix ClassifierReport stuck at WaitingForDelivery in all modes - #491
Merged
Conversation
`ClassifierReport.Status.Phase` was staying at `WaitingForDelivery` forever, in every deployment mode, because nothing in `classifier` ever advanced it. This behavior was different than the sibling `HealthCheckReport`/`EventReport` pipelines in healthcheck-manager event-manager, which explicitly mark `Processed` once a report is collected. This PR makes classifier behavior inline with healthcheck-manager and event-manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassifierReport.Status.Phasewas staying atWaitingForDeliveryforever, in every deployment mode, because nothing inclassifierever advanced it.This behavior was different than the sibling
HealthCheckReport/EventReportpipelines in healthcheck-manager event-manager, which explicitly markProcessedonce a report is collected.This PR makes classifier behavior inline with healthcheck-manager and event-manager