Repository navigation
fix: publish all of lib with a files field instead of .npmignore - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm packages @promaster-sdk/api-server@4.0.1 and 4.0.2 contain only 4 files:
lib/index.js does export * from "./publish/index.js" (and client-rest, client-graphql, file-types), but those folders are not in the package. There are no .d.ts files either. Installing 4.0.1 or 4.0.2 therefore fails at runtime and in tsc, for example Cannot find module '@promaster-sdk/api-server/lib/publish/middleware'. latest currently points to 4.0.2. 4.0.0 is fine (143 files).
The git tags and the Docker image (dividab/promaster-public-api:v4.0.2) are not affected. The Dockerfile builds from source and copies the whole lib/, which is why the image works.
Cause
.npmignore is:
With this file, pnpm pack / pnpm publish keeps only lib/index.js and drops every subfolder of lib/. npm pack handles the same file correctly, and so do pnpm 10 and 11.
Fix