Repository navigation
exp/api/remote: validate confirmation before writing stats headers - #2153
Open
AdamMagued wants to merge 2 commits into
Open
AdamMagued wants to merge 2 commits into
AdamMagued wants to merge 2 commits into
Conversation
Refactor writeHeaders to check confirmation and validity of WriteResponseStats prior to emitting remote write statistics headers. Add constructors and helper methods on WriteResponse and WriteResponseStats to support setting and inspecting confirmation state. Fixes prometheus#2129 Signed-off-by: AdamMagued <adamismailmageud@gmail.com>
Signed-off-by: AdamMagued <adamismailmageud@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
exp/api/remote/remote_headers.go,writeHeaderspreviously checked onlymsgType != WriteV1MessageTypeto decide whether to write the statistics headers (writtenSamplesHeader,writtenHistogramsHeader,writtenExemplarsHeader). Unconfirmed stats (such as default unpopulated stats instances) were emitted as zeros for non-v1 requests, which conflicted with PRW 2.0 confirmation semantics where missing headers indicate unconfirmed metrics.This change refactors
writeHeadersand the stats models:shouldWriteStatsHeaderschecking message type validity, exclusion of v1 messages, stats confirmation status, and metric non-negativity.ConfirmedandSetConfirmedmethods onWriteResponseStats(promoted onWriteResponse).Validatemethod onWriteResponseStatsto verify metric counts are non-negative.NewWriteResponseStats,NewConfirmedWriteResponseStats, andNewWriteResponseWithStatsconstructors.SetStatsmethod onWriteResponse.Addoperations when either operand is confirmed.Fixes #2129