Skip to content

ci: check in Cargo.lock and build with --locked#306

Merged
krisztianfekete merged 2 commits into
prometheus:masterfrom
krisztianfekete:deps/pin-time-dev-dep
Jun 19, 2026
Merged

ci: check in Cargo.lock and build with --locked#306
krisztianfekete merged 2 commits into
prometheus:masterfrom
krisztianfekete:deps/pin-time-dev-dep

Conversation

@krisztianfekete

@krisztianfekete krisztianfekete commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Initial approach:

New approach:

  • Check in Cargo.lock and pass --locked in CI for reproducible builds, as suggested in review. This holds the time dep at a version that compiles, working around the regression above.

@mxinden

mxinden commented Jun 12, 2026

Copy link
Copy Markdown
Member

Given this being a dev-dependency, how about checking in a Cargo.lock? Despite this being a library, I consider this a best practice for a reproducible CI anyways.

@krisztianfekete

Copy link
Copy Markdown
Collaborator Author

Given this being a dev-dependency, how about checking in a Cargo.lock? Despite this being a library, I consider this a best practice for a reproducible CI anyways.

That has been my original idea, but thought it's not the pattern we'd like to follow here given it has never been committed to the repo, and CI lacked --locked. Happy to switch to that approach instead.

Signed-off-by: krisztianfekete <git@krisztianfekete.org>
@krisztianfekete krisztianfekete force-pushed the deps/pin-time-dev-dep branch from b2d9cd1 to e9300ca Compare June 12, 2026 11:49
@krisztianfekete krisztianfekete changed the title deps: pin time dev-dependency to 0.3.47 ci: check in Cargo.lock and build with --locked Jun 12, 2026
@krisztianfekete

Copy link
Copy Markdown
Collaborator Author

@mxinden, can you please take a look when you have a chance?

@krisztianfekete

Copy link
Copy Markdown
Collaborator Author

@mxinden sorry for the ping, but I'd like to fix the upstream time issue and complete cutting the release, so was wondering if you could review the PR?

Signed-off-by: krisztianfekete <git@krisztianfekete.org>
@krisztianfekete

Copy link
Copy Markdown
Collaborator Author

@mxinden, the upstream problem has been resolved, my release is out, but could use a review/approve when you have a chance. Thank you!

@korniltsev-grafanista

Copy link
Copy Markdown

This change aligns with https://blog.rust-lang.org/2023/08/29/committing-lockfiles/

@krisztianfekete

Copy link
Copy Markdown
Collaborator Author

@mxinden, gentle ping.

@mxinden mxinden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krisztianfekete krisztianfekete added this pull request to the merge queue Jun 19, 2026
Merged via the queue into prometheus:master with commit 0b8976e Jun 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants