ci: check in Cargo.lock and build with --locked#306
Conversation
|
Given this being a dev-dependency, how about checking in a |
That has been my original idea, but thought it's not the pattern we'd like to follow here given it has never been committed to the repo, and CI lacked |
Signed-off-by: krisztianfekete <git@krisztianfekete.org>
b2d9cd1 to
e9300ca
Compare
|
@mxinden, can you please take a look when you have a chance? |
|
@mxinden sorry for the ping, but I'd like to fix the upstream |
Signed-off-by: krisztianfekete <git@krisztianfekete.org>
|
@mxinden, the upstream problem has been resolved, my release is out, but could use a review/approve when you have a chance. Thank you! |
|
This change aligns with https://blog.rust-lang.org/2023/08/29/committing-lockfiles/ |
|
@mxinden, gentle ping. |
Initial approach:
New approach:
--lockedin CI for reproducible builds, as suggested in review. This holds the time dep at a version that compiles, working around the regression above.