fix: improve panic message for unknown encoder format - #999
Open
AruneshDwivedi wants to merge 1 commit into
Open
AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
The NewEncoder function panicked with an opaque format string when passed an unknown format, providing no guidance to users on how to resolve the misconfiguration. Add a suggestion to use a valid Format or the NewFormat constructor with a known FormatType. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
Member
|
Is this really helping? If you have unknown format isn't it obvious you need to provide known one? NewFormat does not help as it can return Unknown one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NewEncoder function panics with an opaque format string when passed an unknown format, providing no guidance to users on how to resolve the misconfiguration. This improves the panic message to suggest using a valid Format or the NewFormat constructor with a known FormatType.