proposal: Allow unquoted Unicode letters and dots in metric and label names - #94
roidelapluie wants to merge 3 commits into
Conversation
… names Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
|
Sounds good to me, thanks 👍 I don't know how annoying it will be to implement this behind a feature flag, especially since case differentiation in lexing/parsing (both backend + frontend) could become cumbersome. If that turns out to be too much trouble, maybe we can even relax the requirement that it needs to be behind a feature flag. Btw. I started a vibe-coded implementation in https://github.com/prometheus/prometheus/tree/juliusv-vibe/promql-unquoted-dots a few weeks back just to explore things, see commit prometheus/prometheus@87e9695. That still doesn't cover everything (e.g. printing in the backend or frontend), but feel free to ignore that branch or use it as an inspiration (or copy whatever you like). Maybe one thing to note that popped up in that session: the frontend's lezer parsing system does not have an equivalent of That sounds like it would allow the user to input characters that parse fine on the frontend but cause an error on the backend. Would be nice if there was a better solution, but I haven't looked into it myself yet. |
No description provided.