Conversation
Adds a proposal for a new `prometheus/ui-common` repository for shared React components and design tokens shared by Alertmanager, Prometheus, and Docs. Today these are all separate Mantine/React projects with copied components and design tokens. This copying creates mutiple locations to implement fixes and this gets harder over time as library versions drift. A separate repo provides the ability to release versions independent of the versioning of consuming projects. Alertmanager is in the process of rewriting its UI onto React/Mantine, so now is a good time to standardize design and components and set the long term direction. Signed-off-by: Joe Adams <github@joeadams.io>
Signed-off-by: Joe Adams <github@joeadams.io>
Signed-off-by: Joe Adams <github@joeadams.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a proposal for a new
prometheus/ui-commonrepository for shared React components and design tokens shared by Alertmanager, Prometheus, and Docs. Today these are all separate Mantine/React projects with copied components and design tokens. This copying creates mutiple locations to implement fixes and this gets harder over time as library versions drift.A separate repo provides the ability to release versions independent of the versioning of consuming projects.
Alertmanager is in the process of rewriting its UI onto React/Mantine, so now is a good time to standardize design and components and set the long term direction.
This proposal was drafted by Claude, edited by myself, after working with Claude on the idea, research, and direction.