Skip to content

Document explicit MCP verification and Vault replacement - #4

Merged
chrisjleal merged 1 commit into
mainfrom
codex/mcp-review-freeze-20261010
Oct 11, 2026
Merged

chrisjleal merged 1 commit into
mainfrom
codex/mcp-review-freeze-20261010

Conversation

@chrisjleal

Copy link
Copy Markdown
Contributor

Change

Document direct verification, prepare/submit signing, and same-alias Vault replacement.

Evidence

  • Docs validation passed in workspace ssot:release-gate.

Acceptance boundary

Publish with accepted protocol and package versions after live E2E and reviewer scan.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T18:37:29.516235Z 03008ac PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 03008acdc9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mcp/verify.mdx
```

Signed-in sessions do not send `signature` or `signedTimestamp`. Those fields exist only when the session cannot authorize the account.
The direct tool does not ask for a signature. For a separate signer, pass the `walletAddress`, `verifierIds`, `data`, and `chain` used in preparation to `proofable_verify_submit`, together with the returned `signedTimestamp` and the signature over `signerString`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Carry publish options into the submit call

For the separate-signer flow, this list omits the options object documented immediately above. A caller that prepares with options.publishToHub: true and then follows this instruction will submit without that option; the verification API defaults a missing publishToHub to false (openapi/public-api.json:247-253), so the proof is created offchain instead of being published. Instruct callers to pass the original options—or, more generally, every prepared request field—unchanged to proofable_verify_submit.

Useful? React with 👍 / 👎.

@chrisjleal
chrisjleal merged commit 765ff49 into main Oct 11, 2026
2 checks passed
@chrisjleal
chrisjleal deleted the codex/mcp-review-freeze-20261010 branch October 11, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant