Repository navigation
Document explicit MCP verification and Vault replacement - #4
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03008acdc9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ``` | ||
|
|
||
| Signed-in sessions do not send `signature` or `signedTimestamp`. Those fields exist only when the session cannot authorize the account. | ||
| The direct tool does not ask for a signature. For a separate signer, pass the `walletAddress`, `verifierIds`, `data`, and `chain` used in preparation to `proofable_verify_submit`, together with the returned `signedTimestamp` and the signature over `signerString`. |
There was a problem hiding this comment.
Carry publish options into the submit call
For the separate-signer flow, this list omits the options object documented immediately above. A caller that prepares with options.publishToHub: true and then follows this instruction will submit without that option; the verification API defaults a missing publishToHub to false (openapi/public-api.json:247-253), so the proof is created offchain instead of being published. Instruct callers to pass the original options—or, more generally, every prepared request field—unchanged to proofable_verify_submit.
Useful? React with 👍 / 👎.
Change
Document direct verification, prepare/submit signing, and same-alias Vault replacement.
Evidence
ssot:release-gate.Acceptance boundary
Publish with accepted protocol and package versions after live E2E and reviewer scan.