Skip to content

[DRAFT] Spatz integration#168

Draft
Bumblebee00 wants to merge 88 commits into
pulp-platform:develfrom
Bumblebee00:spatz-integration
Draft

[DRAFT] Spatz integration#168
Bumblebee00 wants to merge 88 commits into
pulp-platform:develfrom
Bumblebee00:spatz-integration

Conversation

@Bumblebee00

@Bumblebee00 Bumblebee00 commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown

This pr aims to add Spatz platform

Added

  • Deeploy/Targets/Spatz/Deployer.py, Platform.py have been added (but for now SpatzMapping contains only the mapping of Add that is from Deeploy.Targets.Generic.Bindings)
  • DeeployTest/Platforms/Spatz/main.c, DeeployTest/testUtils/platformMapping.py to be able to generate c code. The generated c code I tested it compiling manually and executing on the Questa Sim-64 simulator

Changed

  • nothing

Fixed

  • nothing

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR reviewed and approved.
  3. All checks are passing.
  4. The CHANGELOG.md file has been updated.
  5. If the docker was modified, change back its link after review.

Bumblebee00 and others added 30 commits March 2, 2026 19:31
@Bumblebee00
add placeholdeer code for spatz platform
86cfce6
@Bumblebee00
code generation with generic c code
0774556
@Bumblebee00
modified spatz c code to use proper memory allocation and copying fun…
a8fd323 
…ctions
@Bumblebee00
tmp commit to send to badie103
bbf2751
modified Makefile and cmakefiles to build and use spatz runtime. ugly…
b1a5868 
… version
vsim simulator runnable by deeployRunner
0acf6e7
Removed reverence to conda environment and added commands to create v…
8e4e8c3 
…env in the makefile
typo
9cab786
double gvsoc temporaney configuration
e3c46c4
reunited gvsoc build for spatz and other platforms
651d4cf
forgot comment
908261d
forgot comment
edc461f
added topk generic binding (hardcoded k=10)
cd13ce4
added matmul softmax and topk generic bindings to spatz
f72e147
switched default simulator to gvsoc bc is faster
93db81b
added topk test network
eee910c
added sparse attention test network
1523825
added topk binding to generic platform
8b99e3a
improved generic gather node to support more than one index
b541e17
added gather binding for spatz
e35433d
now for any k inot the graph
7eb2e35
added big attention
8f99e67
first draft of tiling (not working)
bfcdda6
minimalloc fix
bdcdd70
fixed makefile adding missing things
64e3874
added yaml for my conda environment
23017e8
modified bindings to use snrt_dma_wait_all function
8b46fd5
added different dimensions of FP32/MatMul
3187d64
fixed simulation staling issue
1624642
fixed memory levels
08ddf29
Bumblebee00 and others added 21 commits May 22, 2026 10:18
cleaner matmul template
a1cfdd1
initial version of dynamic dma code
3360028
fixed sizes of gather template
61bc767
fixed sizes of gather template
da83d8b
fixed gather tile contraint (removed contraint on tile fo data_in)
b51d1c7
removed unnecessary prints
84c1a9a
modified matmul variable to be bigger integers
124b5b3
removed very long memcopy
5f723c4
added hw barrier
a1a83bb
added new tests
b61b850
added another main.c for spatz
d57d8b6
improved hack to avoid memcpy
be21c13
new faster expf function, and softmax smartly devided between cores
d2f342e
minor fixes
82cc8a6
added new template for topk that uses min heap
aeeef40
smal fix
4c72054
added topk function
7b6f9b2
added new test networks
a297ec9
work on matmul kernel
cb6b34a
[fix] enforce 8-byte alignment for memory allocation
e817f2f
[fix] 8-byte aligned tiling constraints
40661ea
@bowwwang bowwwang added the Feature Addition of new features label Jun 12, 2026
bowwwang
bowwwang requested changes Jun 20, 2026
View reviewed changes

@bowwwang bowwwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Mattia,

Thank you very much for the hard work. In this review, we focus on which files are necessary for a commit. I would advise you to remove all the unnecessary tests, including the input/output, and the network generated, so we keep a clean work tree.

After this, we can do a more detailed review of the implementation quality and eventually make your contribution visible to the world.

Comment thread ...Spatz/main_for when the network has two inputs the firtst float32_t and the second int32_T.c

@bowwwang bowwwang Jun 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file

Comment thread DeeployTest/Tests/Kernels/FP32/MatMul/Big/network.onnx

@bowwwang bowwwang Jun 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unreadable somehow. Is this MatMul/Big test is necessary to upstream it to main, or it is only for testing?

Comment thread DeeployTest/Tests/Kernels/FP32/MatMul/MatMul1.128.1024/inferred_network.onnx

@bowwwang bowwwang Jun 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all the unnecessary test cases and the generated data and networks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowwwang bowwwang bowwwang requested changes

@Victor-Jung Victor-Jung Awaiting requested review from Victor-Jung Victor-Jung will be requested when the pull request is marked ready for review Victor-Jung is a code owner

@Xeratec Xeratec Awaiting requested review from Xeratec Xeratec will be requested when the pull request is marked ready for review Xeratec is a code owner

@runwangdl runwangdl Awaiting requested review from runwangdl runwangdl will be requested when the pull request is marked ready for review runwangdl is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@bowwwang bowwwang

@Bumblebee00 Bumblebee00

Labels

Feature Addition of new features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bumblebee00 @bowwwang