Repository navigation
[FIX] Count a passed datetime as overdue in the morning digest - #143
Merged
Merged
Conversation
The 07:00 split compared the raw deadline text with today's date. A datetime sorts after that date, so an instant that had already passed was filed under DUE TODAY, and so was a deadline the overdue filter cannot read.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
puretensor
force-pushed
the
grok/review/morning-digest-overdue
branch
from
October 25, 2026 05:39
1dd1a13 to
bfcc58c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seat: grok-4.7 / xhigh (adversarial review wave 7, 2026-10-25)
Category: [FIX]
Problem / Opportunity: The 07:00 London digest asks the filter for
today | overdue, then splits that list by comparing the raw deadline text with today's date. A datetime sorts after the date-only string"YYYY-MM-DD", so an instant that has already passed is filed under DUE TODAY. A deadlineoverduecannot read (juliandayis NULL, including a 10-character string that only looks like a date) is filed there too.docs/dsl.mdsays those rows are overdue.Evidence: On the unfixed split, with the deadline written by SQL after
create(create normalises an offset into UTC and hides the comparison):2026-10-25T00:00:00+14:00is 10:00 UTC the previous day. SQLite agrees the instant is before noon UTC:The same split files
not-a-dateandabcd-ef-ghunder DUE TODAY (abcd-ef-ghsorts after2026-10-25):The
overduearm incrates/ptask-core/src/filter.rsisjulianday IS NULL, or a 10-character date before today, or a longer datetime whosejuliandayis before now.docs/dsl.mdstates the same rule.Change:
morning_row_is_overduekeeps a realYYYY-MM-DDdate on the date-only rule (due all day). Any other deadline is overdue oncedates::parse_iso_to_utcsays its instant is before now, and overdue when that parse fails. An empty deadline stays under DUE TODAY, so a row included only becausedue_atis today is unchanged. Version 3.51.6 in the workspace package, the six internal requirements,Cargo.lock, anddocs/gen/pt.1.Verification: On this branch, toolchain 1.98.1:
The workspace suite, native-ml, and the dashboard sidecar were not run.
v3.51.6: count a passed datetime as overdue in the morning digest.